Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect YAML syntax highlighting for version numbers with multiple periods #4827

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

andrewnester
Copy link
Contributor

Issue #, if available: #4468

Description of changes:
Fixed incorrect YAML syntax highlighting for version numbers with multiple periods

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@andrewnester andrewnester requested a review from nightwing June 21, 2022 15:23
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #4827 (e130e89) into master (44b6c12) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4827      +/-   ##
==========================================
+ Coverage   71.11%   71.16%   +0.05%     
==========================================
  Files         554      554              
  Lines       55715    55715              
  Branches    10420    10420              
==========================================
+ Hits        39620    39648      +28     
+ Misses      16095    16067      -28     
Flag Coverage Δ
unittests 71.16% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/mode/yaml_highlight_rules.js 86.84% <ø> (ø)
lib/ace/editor.js 81.63% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b6c12...e130e89. Read the comment docs.

@nightwing
Copy link
Member

Should we still highlight .1 as a number it is usually interpreted as a number in most languages? If not highlighting it is intentional the pull request looks good to me.

@andrewnester andrewnester merged commit 915fcaf into ajaxorg:master Jun 22, 2022
@andrewnester andrewnester deleted the bug/4468 branch June 22, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants