Fix documentElement was null in rare cases
#4981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightwing
reviewed
Nov 3, 2022
src/lib/dom.js
Outdated
| var body = document.documentElement; | ||
| body.appendChild(outer); | ||
| var body = (doc && doc.documentElement) || (document && document.documentElement); | ||
| if (body) { |
There was a problem hiding this comment.
it is better to do if (!body) return 0;,
…ave `documentElement`
mkslanc
force-pushed
the
template-ace-bug
branch
from
d839dc5 to
469d587
Compare
Codecov ReportBase: 86.08% // Head: 86.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4981 +/- ##
==========================================
+ Coverage 86.08% 86.09% +0.01%
==========================================
Files 544 546 +2
Lines 41511 41550 +39
Branches 6547 6549 +2
==========================================
+ Hits 35735 35774 +39
Misses 5776 5776
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #4634
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.