Update ace.d.ts typings for navigate #5011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 86.11% // Head: 86.11% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #5011 +/- ##
=======================================
Coverage 86.11% 86.11%
=======================================
Files 546 546
Lines 41627 41627
Branches 6555 6555
=======================================
Hits 35847 35847
Misses 5780 5780
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
andrewnester
suggested changes
Dec 12, 2022
andrewnester
approved these changes
Dec 12, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The typings navigateUp/Down/LeftRight are missing the times parameter. This just adds them to match the function definition.
This will show errors in an IDE:
editor.navigateUp(3)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.