feat: Added Editor API to set the ghost text #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 86.11% // Head: 86.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5036 +/- ##
==========================================
+ Coverage 86.11% 86.13% +0.02%
==========================================
Files 546 546
Lines 41627 41677 +50
Branches 6555 6563 +8
==========================================
+ Hits 35847 35899 +52
+ Misses 5780 5778 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nightwing
approved these changes
Jan 24, 2023
|
|
||
| .ace_ghost_text { | ||
| opacity: 0.5; | ||
| font-style: italic; |
There was a problem hiding this comment.
Chrome console doesn't use italic, which makes it look more like the part of the typed word. I think it is better but maybe it's just a matter of getting used to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added new
Editormethodsset/removeGhostTextto work with the ghost text."Ghost" text is a kind of a preview text inside the editor which can be used to preview some code inline in the editor such as, for example, code completions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.