Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MySQL highlighting mode #5050

Merged
merged 14 commits into from
Feb 5, 2023
Merged

Improve MySQL highlighting mode #5050

merged 14 commits into from
Feb 5, 2023

Conversation

rozhnev
Copy link
Contributor

@rozhnev rozhnev commented Feb 3, 2023

Improve MySQL highlighting mode:

  • separate dataTypes highlighting mode
  • added timestamp dataTypes
  • 'by' keyword moved from builtins to mySqlKeywords
  • date|time|timestamp moved from constants to builtins
    Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 86.13% // Head: 86.14% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6169aef) compared to base (95e9664).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5050   +/-   ##
=======================================
  Coverage   86.13%   86.14%           
=======================================
  Files         546      548    +2     
  Lines       41677    41703   +26     
  Branches     6563     6563           
=======================================
+ Hits        35900    35926   +26     
  Misses       5777     5777           
Flag Coverage Δ
unittests 86.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mode/mysql_highlight_rules.js 100.00% <100.00%> (ø)
src/mode/plsql.js 100.00% <100.00%> (ø)
src/mode/plsql_highlight_rules.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrewnester andrewnester merged commit 00f6089 into ajaxorg:master Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants