Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with missing token in latex folding #5093

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Mar 15, 2023

Issue #, if available: #5090

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (16a13ce) 86.20% compared to head (637dda4) 86.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5093      +/-   ##
==========================================
+ Coverage   86.20%   86.31%   +0.10%     
==========================================
  Files         548      549       +1     
  Lines       41704    41737      +33     
  Branches     6564     6568       +4     
==========================================
+ Hits        35953    36024      +71     
+ Misses       5751     5713      -38     
Flag Coverage Δ
unittests 86.31% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mode/folding/latex.js 56.04% <100.00%> (+41.75%) ⬆️
src/mode/folding/latex_test.js 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@InspiredGuy
Copy link
Contributor

@mkslanc the fix looks good, but the coverage check for the patch failed. Could you please add a simple test for the function you modified, so this bug does not reappear again? I see we have tests for some other modes already.

@mkslanc
Copy link
Contributor Author

mkslanc commented Mar 15, 2023

Sure, added test similar to other folding tests

@InspiredGuy InspiredGuy merged commit 44b3a3e into ajaxorg:master Mar 16, 2023
akoreman pushed a commit to akoreman/ace that referenced this pull request Mar 19, 2023
* fix bug with missing token

* add test for latex folding

Issue ajaxorg#5090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants