bug(autocomplete): fix a11y violations #5241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility violations for autocompletion popover are fixed.
role=listbox
is moved to$textLayer
oface_autocomplete
editor to make its direct children haverole=option
, otherwise there isaria-required-children
violation (https://dequeuniversity.com/rules/axe/4.5/aria-required-children?application=axeAPI)aria-hidden
set fortextarea
of autocomplete popover (there istextarea
there since it is an editor instance).aria-posinset
now starts from 1.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.