Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for time units in PRQL #5324

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

vanillajonathan
Copy link
Contributor

Description of changes:

  • Adds support for time units (e.g. years, months, days, etc).
  • Change the token comment.block to comment.block.documentation.
  • Change the token comment.line to comment.line.number-sign.
  • Change the tokens string to string.single and string.double.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (678364b) 87.40% compared to head (3442a15) 87.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5324   +/-   ##
=======================================
  Coverage   87.40%   87.40%           
=======================================
  Files         574      574           
  Lines       45587    45588    +1     
  Branches     6935     6935           
=======================================
+ Hits        39845    39846    +1     
  Misses       5742     5742           
Flag Coverage Δ
unittests 87.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/mode/prql_highlight_rules.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@InspiredGuy InspiredGuy merged commit 8b9175b into ajaxorg:master Oct 9, 2023
3 checks passed
@InspiredGuy
Copy link
Contributor

Thank you for the contribution.

@vanillajonathan vanillajonathan deleted the patch-1 branch October 9, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants