Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete: Screen reader doesn't read suggestions on Safari #5377

Closed
oykuyilmaz opened this issue Oct 31, 2023 · 3 comments · Fixed by #5403
Closed

Autocomplete: Screen reader doesn't read suggestions on Safari #5377

oykuyilmaz opened this issue Oct 31, 2023 · 3 comments · Fixed by #5403
Labels
bug effort/medium p1

Comments

@oykuyilmaz
Copy link
Contributor

oykuyilmaz commented Oct 31, 2023 •
edited
Loading

Describe the bug

Triggering autocomplete and navigating completions is not mentioned in screen reader on Safari.

Expected Behavior

Autocomplete popover is accessible to screen reader users.

Reproduction Steps

  1. Open https://ace.c9.io/kitchen-sink.html
  2. Start VoiceOver
  3. Ctrl + Space to trigger autocomplete

Ace Version / Browser / OS / Screen Reader

1.31.1/Safari/MacOS/VoiceOver
@oykuyilmaz oykuyilmaz changed the title Autocomplete: Screen reader does not read suggestions on Safari Autocomplete: Screen reader doesn't read suggestions on Safari Oct 31, 2023
@oykuyilmaz
Copy link
Contributor Author

Works as expected on Chrome.

@marinsokol5
Copy link
Contributor

Can confirm that Chrome and Firefox work correctly but Safari 16.6 doesn't.
Unsure if this is a Safari problem but we should definitely investigate if there is something we can do for those users.

@oykuyilmaz
Copy link
Contributor Author

We use aria-activedescendant attribute for the current selection on autocomplete popover with listbox role. Screen reader support expectations are as following for this attribute:
https://a11ysupport.io/tech/aria/aria-activedescendant_attribute

@akoreman akoreman mentioned this issue Nov 28, 2023
Merged
@akoreman akoreman linked a pull request Nov 28, 2023 that will close this issue
fix: set completion popup role to 'menu' for safari #5403
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug effort/medium p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set completion popup role to 'menu' for safari akoreman/ace
2 participants
@oykuyilmaz @marinsokol5