feat: adding CloudEditor theme #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoreman
approved these changes
Nov 29, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5404 +/- ##
=======================================
Coverage 87.54% 87.54%
=======================================
Files 583 583
Lines 46253 46253
Branches 7003 7003
=======================================
Hits 40493 40493
Misses 5760 5760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andredcoliveira
approved these changes
Nov 29, 2023
src/ext/themelist.js
Outdated
| @@ -24,6 +24,7 @@ var themeData = [ | |||
| ["Kuroir"], | |||
| ["KatzenMilch"], | |||
| ["SQL Server" ,"sqlserver" , "light"], | |||
| ["CloudEditor", "cloud_editor", "light"], | |||
There was a problem hiding this comment.
nitpick: Could you use the same formatting convention that's used for others? I.e., aligning indexes vertically
src/ext/themelist.js
Outdated
| @@ -48,7 +49,8 @@ var themeData = [ | |||
| ["Tomorrow Night 80s" ,"tomorrow_night_eighties" , "dark"], | |||
| ["Twilight" ,"twilight" , "dark"], | |||
| ["Vibrant Ink" ,"vibrant_ink" , "dark"], | |||
| ["GitHub Dark" ,"github_dark" , "dark"] | |||
| ["GitHub Dark" ,"github_dark" , "dark"], | |||
| ["CloudEditor Dark", "cloud_editor_dark", "dark"] | |||
There was a problem hiding this comment.
nitpick: Similar comment as above: could you use the same formatting convention that's used for others? I.e., aligning indexes vertically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new accessible modern theme for Ace