fix: prevent browser scroll while scrolling over the tooltip #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5414 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 583 584 +1
Lines 46369 46398 +29
Branches 7016 7019 +3
=======================================
+ Hits 40610 40640 +30
+ Misses 5759 5758 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nightwing
reviewed
Dec 11, 2023
| @@ -580,13 +580,20 @@ class Autocomplete { | |||
| this.tooltipNode = dom.createElement("div"); | |||
| this.tooltipNode.style.margin = 0; | |||
| this.tooltipNode.style.pointerEvents = "auto"; | |||
| this.tooltipNode.style.overscrollBehavior = "contain"; | |||
There was a problem hiding this comment.
It is for doc-tooltips of autocomplete items, they are also scrollable.
src/tooltip.js
Outdated
| el.addEventListener("wheel", function(event) { | ||
| event.stopPropagation(); | ||
| var contentOverflows = el.scrollHeight > el.clientHeight; | ||
| if (!contentOverflows) { |
There was a problem hiding this comment.
can we use event.target here, rename this function to something like preventParentScroll move to lib and use in both places?
nightwing
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Prevents browser scroll when a non-scrollable tooltip is open and you scroll on the tooltip.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.