Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ace-code): Incorrect typings for 'ace-code/src/mode/swift_highlight_rules' #5511

Closed
just-boris opened this issue Mar 15, 2024 · 4 comments
Closed

Comments

@just-boris
Copy link

just-boris commented Mar 15, 2024

Describe the bug

The typings for swift_highlight_rules do not match the actual behavior

// import according to the types
import { SwiftHighlightRules } from "ace-code/src/mode/swift_highlight_rules";

// actual import, works in runtime, but broken in typescript
import { HighlightRules } from "ace-code/src/mode/swift_highlight_rules";

Ace Version / Browser / OS / Keyboard layout

1.32.3

@andredcoliveira
Copy link
Contributor

Hey, @just-boris! Is this something you could submit a PR for?

@just-boris
Copy link
Author

I think there is a fundamental issue with your project, that such integrations are not tested properly. It is not something which an external contributor can fix.

For my tasks I already unblocked myself, see the linked pr, I could just remove the dependency on the problematic code.

@andredcoliveira
Copy link
Contributor

In terms of the fundamental issue: Ace is a vanilla JavaScript project and we're adding type-checking capabilities to it incrementally to improve our testing posture.

In terms of this specific issue, despite your mitigation: does #5516 fix it?

@just-boris
Copy link
Author

Yes, that works. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants