Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contrast completion meta contrast cloud editor themes #5558

Merged
merged 2 commits into from
May 21, 2024

Conversation

akoreman
Copy link
Contributor

Issue #, if available: NA

Description of changes: Fix contrast of completion meta tag in Cloud Editor themes to comply with 4.5:1 contrast requirement.

Screenshot 2024-05-21 at 17 43 59 Screenshot 2024-05-21 at 17 44 06

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.66%. Comparing base (b3dfa11) to head (d30b021).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5558   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files         593      593           
  Lines       42920    42920           
  Branches     7125     7125           
=======================================
  Hits        37198    37198           
  Misses       5722     5722           
Flag Coverage Δ
unittests 86.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit b8877f0 into ajaxorg:master May 21, 2024
3 checks passed
@akoreman akoreman deleted the cloudeditor_theme_fix branch May 21, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants