Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always set aria-label to text input in a11y mode #5563

Merged
merged 5 commits into from
May 24, 2024

Conversation

akoreman
Copy link
Contributor

Issue #, if available: NA

Description of changes: We recently allowed users to set custom aria-labels to the text input, we currently only set the label on focus which makes it hard for users to find their custom label for their first input. This fixes that by always setting the label.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (2330d80) to head (dd9c26b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5563   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files         593      593           
  Lines       42940    42951   +11     
  Branches     7126     7126           
=======================================
+ Hits        37218    37229   +11     
  Misses       5722     5722           
Flag Coverage Δ
unittests 86.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit 00346fd into ajaxorg:master May 24, 2024
3 checks passed
@akoreman akoreman deleted the aria_label branch May 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants