Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting marker type for MarkerGroups #5630

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

akoreman
Copy link
Contributor

@akoreman akoreman commented Aug 21, 2024

Issue #, if available: NA

Description of changes: When using MarkerGroups, currently, all markers default to being of the text type in which only the text itself is highlighted within a range. Users of MarkerGroups might want to have different types of markers.

This change adds an options parameter to allow setting marker type to fullLine or line. In fullLine, all the rows within the range will be fully highlighted, for line we highlight the same as default but when newlines are part of the range we fill up the highlight from the last character within the line to the right side of the editor.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@akoreman akoreman changed the title Markergroup type feat: allow setting marker type for MarkerGroups Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (605a0d0) to head (4c11922).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5630      +/-   ##
==========================================
+ Coverage   86.95%   86.97%   +0.01%     
==========================================
  Files         594      594              
  Lines       43348    43395      +47     
  Branches     7167     7170       +3     
==========================================
+ Hits        37694    37742      +48     
+ Misses       5654     5653       -1     
Flag Coverage Δ
unittests 86.97% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/marker_group.js Outdated Show resolved Hide resolved
src/marker_group.js Outdated Show resolved Hide resolved
Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@akoreman akoreman merged commit 214df9c into ajaxorg:master Aug 21, 2024
2 checks passed
@akoreman akoreman deleted the markergroup_type branch August 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants