-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting marker type for MarkerGroups #5630
Conversation
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5630 +/- ##
==========================================
+ Coverage 86.95% 86.97% +0.01%
==========================================
Files 594 594
Lines 43348 43395 +47
Branches 7167 7170 +3
==========================================
+ Hits 37694 37742 +48
+ Misses 5654 5653 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Issue #, if available: NA
Description of changes: When using
MarkerGroup
s, currently, all markers default to being of thetext
type in which only the text itself is highlighted within a range. Users ofMarkerGroup
s might want to have different types of markers.This change adds an
options
parameter to allow setting marker type tofullLine
orline
. InfullLine
, all the rows within the range will be fully highlighted, forline
we highlight the same as default but when newlines are part of the range we fill up the highlight from the last character within the line to the right side of the editor.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts
) and its references: