Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #4976

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Documentation #4976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88af815
some typings fixed
anijanyan Oct 19, 2022
b496a08
Merge branch 'master' into documentation
anijanyan Oct 30, 2022
91eb6b8
enableLiveAutocompletion documentation fixed
anijanyan Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ace.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,10 @@ export namespace Ace {
canRedo(): boolean;
bookmark(rev?: number): void;
isAtBookmark(): boolean;
hasUndo(): boolean;
hasRedo(): boolean;
isClean(): boolean;
markClean(rev?: number): void;
}

export interface Position {
Expand Down Expand Up @@ -459,7 +463,7 @@ export namespace Ace {
inFront?: boolean): number;
addDynamicMarker(marker: MarkerLike, inFront: boolean): MarkerLike;
removeMarker(markerId: number): void;
getMarkers(inFront?: boolean): MarkerLike[];
getMarkers(inFront?: boolean): {[id: number]: MarkerLike};
highlight(re: RegExp): void;
highlightLines(startRow: number,
endRow: number,
Expand Down
6 changes: 4 additions & 2 deletions src/ext/language_tools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,12 @@ require("../config").defineOptions(Editor.prototype, "editor", {
value: false
},
/**
* Enable live autocomplete. If the value is an array, it is assumed to be an array of completers
* and will use them instead of the default completers.
* Enable live autocompletion
*/
enableLiveAutocompletion: {
/**
* @param {boolean} val
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still possible to pass an array of completers right?

So instead as suggested in original issue the text should be

Enable basic autocomplete. If the value is an array, it is assumed to be an array of completers and will use them unless you already have completers set e.g. from **enableLiveAutocompletion.**

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The api here is rather strange and not very useful, isn't it better to deprecate passing the array. The users can use completers array directly anyway.

*/
set: function(val) {
if (val) {
if (!this.completers)
Expand Down