Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ws and web-ext #286

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 16, 2024

Bumps ws to 8.17.1 and updates ancestor dependency web-ext. These dependencies need to be updated together.

Updates ws from 8.13.0 to 8.17.1

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Updates web-ext from 7.10.0 to 8.2.0

Release notes

Sourced from web-ext's releases.

8.2.0

features

  • web-ext lint: updated to use addons-linter v6.30.1

bug fixes, etc.

dependencies

  • Updated: dependency jose to 5.4.1 (#3174)
  • Updated: dependency mkdirp to 3.0.1 (#2735)
  • Updated: dependency ws to 8.17.1 (#3171)

See all changes: mozilla/web-ext@8.1.0...8.2.0

8.1.0

features

  • web-ext lint: updated to use addons-linter v6.29.0

bug fixes, etc.

dependencies

  • Updated: dependency @babel/runtime to 7.24.7 (#3160)
  • Updated: dependency jose to 5.4.0 (#3157)

dev dependencies

  • Updated: dependency @babel/cli to 7.24.7 (#3161)
  • Updated: dependency @babel/core to 7.24.7 (#3162)
  • Updated: dependency @babel/eslint-parser to 7.24.7 (#3158)
  • Updated: dependency @babel/preset-env to 7.24.7 (#3159)
  • Updated: dependency chai-as-promised to 8.0.0 (#3165)
  • Updated: dependency nyc to 17.0.0 (#3166)
  • Updated: dependency prettier to 3.3.2 (#3168)

See all changes: mozilla/web-ext@8.0.0...8.1.0

8.0.0

What's changed

300+ commits have been written to get this new version 8 out of the door (see link to the full changelog at the bottom). Please take a look at the official documentation to know what has changed but expect some breaking changes.

Specifically, web-ext sign has been heavily refactored. Among other things, you can create new add-ons (not just versions) from the command line now 🎉 Unfortunately, this command is not backward compatible with v7.

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 16, 2024
@ajayyy
Copy link
Owner

ajayyy commented Sep 2, 2024

@dependabot rebase

Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependency [web-ext](https://github.com/mozilla/web-ext). These dependencies need to be updated together.


Updates `ws` from 8.13.0 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.13.0...8.17.1)

Updates `web-ext` from 7.10.0 to 8.2.0
- [Release notes](https://github.com/mozilla/web-ext/releases)
- [Commits](mozilla/web-ext@7.10.0...8.2.0)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: web-ext
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/multi-4c1fdd2521 branch from 698620e to 60851ad Compare September 2, 2024 20:24
@ajayyy ajayyy merged commit f5ebbdb into master Sep 2, 2024
4 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/multi-4c1fdd2521 branch September 2, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant