Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.1.11 broken in Safari #1626

Closed
seaside98 opened this issue Dec 26, 2022 · 1 comment
Closed

5.1.11 broken in Safari #1626

seaside98 opened this issue Dec 26, 2022 · 1 comment

Comments

@seaside98
Copy link

Commit 35b8a34 added a regex lookbehind (?<=^\s*\(.+) which isn't supported in Safari. The extension crashes with Invalid regular expression: invalid group specifier name.

Safari Version 16.2 (18614.3.7.1.5)
SponsorBlock version 5.1.11
@ajayyy
Copy link
Owner

ajayyy commented Dec 26, 2022

Good catch, I hate that invalid regex breaks the entire JS file (all browsers do this)

@ajayyy ajayyy closed this as completed in 27f3ced Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seaside98 @ajayyy