Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piped integration: website navigation bar is hidden #1865

Closed
acidghost opened this issue Sep 29, 2023 · 7 comments
Closed

Piped integration: website navigation bar is hidden #1865

acidghost opened this issue Sep 29, 2023 · 7 comments

Comments

@acidghost
Copy link

As documented by TeamPiped/Piped#2987 this extension breaks the navigation bar in Piped.

Most of the info is there, I'll repeat my setup:

Let me know if you need more details.

@mchangrh
Copy link
Contributor

mchangrh commented Oct 1, 2023

hmm, I can't reproduce it on firefox or chrome on windows and piped support was added in July If that was the case, then it should have popped up much much much earlier

@acidghost
Copy link
Author

I just reproduced it in an incognito window w/ just SponsorBlock extension enabled.

Are you sure that you're using the same version of Firefox?

@mchangrh
Copy link
Contributor

mchangrh commented Oct 2, 2023

Repro'd on another machine with a fresh FF install, I think it might be maze-utils...

@mchangrh
Copy link
Contributor

mchangrh commented Oct 2, 2023

Found it, it's because of a conflicting css class

<ul class="md:text-1xl hidden md:flex md:flex md:flex-1 md:justify-end md:children:pl-3"> </ul>

.hidden is overriden by an @media display:... property, but sponsorblock's css overrides it...

I'll ping kavin on matrix to discuss..

@ajayyy
Copy link
Owner

ajayyy commented Oct 2, 2023

SponsorBlock shouldn't inject such a generic class name

@mchangrh
Copy link
Contributor

mchangrh commented Oct 2, 2023

Then we might need to refactor some other classes as well

@ghost
Copy link

ghost commented Oct 8, 2023

I can confirm the error occurs and is really annoying

@ajayyy ajayyy closed this as completed in 04a9f82 Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants