Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model training is missing #1

Open
eardic opened this issue Dec 12, 2021 · 1 comment
Open

Model training is missing #1

eardic opened this issue Dec 12, 2021 · 1 comment

Comments

@eardic
Copy link

eardic commented Dec 12, 2021

Why the model is not trained with the new batch at the line below?

new_score = accuracy(self.model(data), labels)

@ajsanjoaquin
Copy link
Owner

Hello @eardic, thanks for spotting the bug. I agree that it should train the model before computing the new score.

Looking at the paper (https://arxiv.org/pdf/1904.02868.pdf), page 4, it says to add a new point in our subset and see if performance (e.g. accuracy) improves compared to the performance with the previous subset.

I'm tied with other projects for now, so I would appreciate if you can submit a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants