October 3-9, 2021 in Darker: Performance optimization and Git integration challenges #661
akaihola
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This week, our focus shifted towards performance optimization and addressing challenges related to Git integration. A significant discussion arose around the SequenceMatcher's suboptimal chunkification (#206), which can lead to unnecessarily large reformatting chunks. We explored various approaches to improve this, including adjusting junk heuristics and considering alternative matching algorithms. One intriguing suggestion was to delegate diff computation to the
git
binary, which could potentially offer better performance and tuning for code.We made progress on performance improvements, particularly in the bisection process. The merged pull request (#214) introduced an ASTVerifier and caching of intermediate data during bisect, addressing issues raised in #211. This change aims to optimize the verification of abstract syntax trees and improve overall performance. Additionally, we addressed a Git integration issue (#203) related to older Git clients, where Darker was crashing with a "not a repository" error when run as a pre-commit hook in subdirectories. We're considering various solutions to ensure compatibility with older Git versions while maintaining functionality.
Beta Was this translation helpful? Give feedback.
All reactions