September 10 - October 1, 2023 in Darker: Pre-commit hook fix and GitHub Action discussions #715
akaihola
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This period saw improvements to our pre-commit hook configuration and further discussions about GitHub Actions. We merged a fix for the pre-commit hook arguments (PR #519), addressing an issue where the
--lint
argument was incorrectly interpreted as a file. The update ensures each argument is on its own line, resolving the call failure.We continued our dialogue about GitHub Actions, focusing on the
revision
option andfetch-depth
settings (Discussion #518). Users reported success using"origin/master..."
instead of"master..."
, suggesting a potential need for documentation updates. The community also explored challenges with limited fetch depth in large repositories, noting that a full history checkout (fetch-depth: 0
) was often necessary for the action to work correctly. These insights may guide future improvements to our GitHub Action configuration and documentation, especially for users working with large monorepos or using additional linting tools like Ruff.Beta Was this translation helpful? Give feedback.
All reactions