Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulls in angular as a dependency #37

Open
stefaneg opened this issue Oct 27, 2015 · 1 comment · May be fixed by #38
Open

Pulls in angular as a dependency #37

stefaneg opened this issue Oct 27, 2015 · 1 comment · May be fixed by #38

Comments

@stefaneg
Copy link

When installing with npm install react-foundation-apps, the post install bower install pulls in angular as a dependency along with foundation-apps. This is not cool for a library which aims to get rid of angular...:-/
@stefaneg
Copy link
Author

FYI, I spent a few hours trying to integrate this lib with my project, which is using brunch as a build tool (does similar things as webpack). Gave up after chasing 10+ dependencies from various directions with no end in sight. This project really needs to cut seriously down on the dependencies to get this to fly IMHO. My advise would be to limit dependencies to react-with-addons.js and foundation site version and try to get rid of every other dependency, including react-tools, PubSub, iconic.min, etc, etc.

@mhamann mhamann linked a pull request Dec 13, 2015 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compatibility with React 0.13+ and React Router 1.x mhamann/react-foundation-apps
1 participant
@stefaneg