Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a favicon isn't set on a feed you follow, a broken image appears in /friends for the post #152

Closed
HammyHavoc opened this issue Jan 2, 2023 · 3 comments

Comments

@HammyHavoc
Copy link
Contributor

See screenshot:

image

@HammyHavoc HammyHavoc changed the title If a favicon isn't set on a feed you follow, a broken image appears in /friends for the blog owner If a favicon isn't set on a feed you follow, a broken image appears in /friends for the post Jan 2, 2023
@gbraad
Copy link

gbraad commented Jan 2, 2023

Resolved as #139 in #142. Not in a released version yet

@akirk
Copy link
Owner

akirk commented Jan 2, 2023

I think this is just via RSS, not ActivityPub. Can you confirm, @HammyHavoc?

@HammyHavoc
Copy link
Contributor Author

HammyHavoc commented Jan 2, 2023

Unfortunately, I've not been able to replicate the issue after adding a favicon and then removing one. I'm going to chalk it up to a Theme bug on Bryan's site, which got resolved by adding a favicon and subsequently removing it.

After removing the favicon, it now displays as what I would expect without a favicon set:

image

I'll let you know if I replicate it at a later point; setting up several sites with Friends plugins today, it's quite exciting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants