Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(promo): honor Argo CD sync windows #2346

Closed
wants to merge 2 commits into from

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Jul 24, 2024

Fixes #2078

Signed-off-by: Remington Breeze <remington@breeze.software>
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit eb20c33
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66a1924decc81d000859c56c
😎 Deploy Preview https://deploy-preview-2346.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Remington Breeze <remington@breeze.software>
@krancour
Copy link
Member

I had been contemplating Kargo having its own windows for things like freight discovery/production, promotions, etc. so things work uniformly for all gitops agents -- this is supposing we support others in the future. But this might be a good interim solution, so let's still consider it. 👀 tomorrow.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0.67114% with 148 lines in your changes missing coverage. Please review.

Project coverage is 47.24%. Comparing base (6dc367b) to head (eb20c33).
Report is 207 commits behind head on main.

Files with missing lines Patch % Lines
...ontroller/argocd/api/v1alpha1/application_types.go 0.00% 124 Missing ⚠️
...troller/argocd/api/v1alpha1/application_helpers.go 0.00% 17 Missing ⚠️
internal/controller/promotion/argocd.go 0.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
- Coverage   47.64%   47.24%   -0.41%     
==========================================
  Files         244      244              
  Lines       17392    17540     +148     
==========================================
  Hits         8287     8287              
- Misses       8694     8841     +147     
- Partials      411      412       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour
Copy link
Member

This is based on legacy promo mechs, which have been fully removed at this point.

This will have to be resolved differently.

@krancour krancour closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kargo does not honor Argo CD sync windows
2 participants