Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite support #7

Closed
piersharding opened this issue Jan 25, 2011 · 4 comments
Closed

sqlite support #7

piersharding opened this issue Jan 25, 2011 · 4 comments

Comments

@piersharding
Copy link

Hi -
I've just installed Lessnmore using sqlite as the backend (mainly for convenience and testing), and have found it works after I removed the BINARY keyword from any of the SQL statements - all around the table urls,

I've hacked this out for my purposes, and I'm not sure how you'd want to deal with this internally (if you want to support sqlite at all).

Cheers,
Piers Harding.

@alanhogan
Copy link
Owner

Thanks for the report, Piers. I’ll tackle this in the next version of Lessn More.

I welcome any patches, forks, or pull requests.

Now I also want to tell you why I added BINARY in the first place — because without it, SQL queries (at least in MySQL!) match regardless of case — this means that if you have two URLs defined with similar cases, e.g. example.com/a and example.com/A — then redirections will probably end up at ONE url no matter which short URL you go to!

Can you confirm for me whether your system is afflicted by this bug or not? For example, set up /foo and /FOO where foo goes to, say, google.com and FOO goes to this page?

Thanks!

@piersharding
Copy link
Author

Hi -

I've checked
example.com/FOO -> AFOO
example.com/foo -> afoo
&
www.bbc.co.uk -> FOO
www.google.com -> foo

and all seems to work as I'd expect - ie it is case sensitive.

Thanks for your work on this - it's just what I need for a friendly URL service inside a K12 school environment.

Cheers,
Piers Harding.

@alanhogan
Copy link
Owner

Excellent, Piers. Thanks for checking that for me. I’ll be sure to address this in the next version.

Glad you’re finding LM useful.

@alanhogan
Copy link
Owner

Addressed this in the latest builds (currently development branch). Let me know if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants