-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amqp_socket_open to port without listener appears to block forever #346
Comments
That seems like a bit of a regression. Could you try it out using the current master branch? I'll do a bit of investigation. |
I checked it with the current master branch, and it seems to be back to the previous behaviour with AMQP_STATUS_SOCKET_ERROR. Still, I cannot determine the socket error code, but it is reasonable to assume that there is no other socket error. |
Is there a chance to release a fixed 0.7.2 version? |
I'm trying to get 0.8.0 out the door, but I haven't found and evening to wrap it up. I'll try and aim to get that done in the next ~week. |
Ok :) Will 0.8.0 introduce any incompatible changes? |
Unless you use one of the non-OpenSSL SSL backends I don't see any incompatible changes. Looking for API changes, this may also be called 0.7.2. |
This was a duplicate of #297. v0.8.0 has been released. |
Thanks, 0.8.0 works fine :) |
In librabbitmq-c 0.5.2, trying to amqp_socket_open to a port where no one was listening, resulted in an AMQP_STATUS_SOCKET_ERROR (unfortunately, the exact socket error could not be determined, cf. #236, but it should probably have been WSAECONNREFUSED (10061) ).
In librabbitmq-c 0.7.1, this behavior has changed, amqp_socket_open now appears to block forever, and amqp_socket_open_noblock completes with a AMQP_STATUS_TIMEOUT
This is unfortunate, as the condition can no longer be distinguished from a real timeout, and the operation only fails after the timeout period.
Has the behaviour changed for a reason? Can the original behaviour be restored?
The text was updated successfully, but these errors were encountered: