Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect README.md statement #834

Closed
SamHerts opened this issue Jun 13, 2024 · 1 comment · Fixed by #835
Closed

Incorrect README.md statement #834

SamHerts opened this issue Jun 13, 2024 · 1 comment · Fixed by #835

Comments

@SamHerts
Copy link

SamHerts commented Jun 13, 2024 •
edited
Loading

README.md is quoted as

rabbitmq-c/README.md

Line 76 in d37e4a3

* `BUILD_EXAMPLES=ON/OFF` toggles building the examples. ON by default.

But the CMakeLists.txt has examples OFF by default

rabbitmq-c/CMakeLists.txt

Line 147 in d37e4a3

option(BUILD_EXAMPLES "Build Examples" OFF)

@SamHerts
Copy link
Author

SamHerts commented Jun 13, 2024 •
edited
Loading

README.md is quoted as

rabbitmq-c/README.md

Lines 79 to 80 in d37e4a3

* `BUILD_STATIC_LIBS=ON/OFF` toggles building rabbitmq-c as a static library.
OFF by default.

But the CMakeLists.txt has static libs ON by default

rabbitmq-c/CMakeLists.txt

Line 144 in d37e4a3

option(BUILD_STATIC_LIBS "Build rabbitmq-c as a static library" ON)

@SamHerts SamHerts mentioned this issue Jun 13, 2024
Merged
@alanxz alanxz linked a pull request Jun 13, 2024 that will close this issue
Update README.md to be consistent with CMakeLists.txt #835
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README.md to be consistent with CMakeLists.txt SamHerts/rabbitmq-c
1 participant
@SamHerts