Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contigous checks output as well #25

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Contigous checks output as well #25

merged 3 commits into from
Jul 31, 2024

Conversation

ternaus
Copy link
Contributor

@ternaus ternaus commented Jul 31, 2024

Summary by Sourcery

This pull request enhances the contiguous decorator to ensure that both input and output arrays are contiguous. It also updates several pre-commit hooks to their latest versions and adds tests to verify the functionality of the updated decorator.

  • Enhancements:
    • Enhanced the contiguous decorator to ensure that both input and output arrays are contiguous.
  • Build:
    • Updated pre-commit hooks: pyproject-fmt to version 2.2.0, ruff-pre-commit to version 0.5.5, and mypy to version 1.11.0.
  • Tests:
    • Added tests to verify that the contiguous decorator ensures both input and output arrays are contiguous.

Copy link
Contributor

sourcery-ai bot commented Jul 31, 2024

Reviewer's Guide by Sourcery

This pull request enhances the contiguous decorator to ensure both input and output arrays are contiguous. Corresponding tests have been added to validate this functionality. Additionally, the versions of several pre-commit hooks have been updated.

File-Level Changes

Files Changes
tests/test_utils.py
albucore/utils.py
Enhanced the contiguous decorator to ensure both input and output arrays are contiguous and added corresponding tests to validate this functionality.
.pre-commit-config.yaml Updated versions of pre-commit hooks for pyproject-fmt, ruff-pre-commit, and mypy.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f3fd587). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage        ?   55.97%           
=======================================
  Files           ?       14           
  Lines           ?     1347           
  Branches        ?        0           
=======================================
  Hits            ?      754           
  Misses          ?      593           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 3 issues found
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

albucore/utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
albucore/utils.py Show resolved Hide resolved
@ternaus ternaus merged commit 9b22ba0 into main Jul 31, 2024
16 checks passed
@ternaus ternaus deleted the update_as_contigouus branch July 31, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants