-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contigous checks output as well #25
Conversation
Reviewer's Guide by SourceryThis pull request enhances the File-Level Changes
Tips
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage ? 55.97%
=======================================
Files ? 14
Lines ? 1347
Branches ? 0
=======================================
Hits ? 754
Misses ? 593
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Summary by Sourcery
This pull request enhances the
contiguous
decorator to ensure that both input and output arrays are contiguous. It also updates several pre-commit hooks to their latest versions and adds tests to verify the functionality of the updated decorator.contiguous
decorator to ensure that both input and output arrays are contiguous.contiguous
decorator ensures both input and output arrays are contiguous.