Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #40

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix CI #40

merged 2 commits into from
Oct 21, 2024

Conversation

ternaus
Copy link
Contributor

@ternaus ternaus commented Oct 21, 2024

Summary by Sourcery

Update the CI configuration by removing Python 3.8 from the testing matrix and update the mypy pre-commit hook to version 1.12.1.

CI:

  • Remove Python 3.8 from the CI testing matrix.

Chores:

  • Update mypy pre-commit hook to version 1.12.1.

Copy link
Contributor

sourcery-ai bot commented Oct 21, 2024

Reviewer's Guide by Sourcery

This pull request focuses on updating the CI configuration and pre-commit hooks. It removes Python 3.8 from the test matrix and updates the mypy version in the pre-commit configuration.

Architecture diagram for updated CI configuration

graph TD;
    A[CI Workflow] --> B[Matrix Configuration];
    B --> C[Operating Systems: ubuntu-latest, windows-latest, macos-13];
    B --> D[Python Versions: 3.9, 3.10, 3.11, 3.12];
    A --> E[Pre-commit Hooks];
    E --> F[Mypy Version: v1.12.1];
Loading

File-Level Changes

Change Details Files
Update CI configuration
  • Remove Python 3.8 from the test matrix
  • Keep Python versions 3.9, 3.10, 3.11, and 3.12
.github/workflows/ci.yml
Update pre-commit hooks
  • Upgrade mypy version from v1.12.0 to v1.12.1
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding more context to the PR description, especially regarding the removal of Python 3.8 support and the rationale behind the CI changes. This helps maintain clear documentation of compatibility changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ternaus ternaus merged commit 8abf991 into main Oct 21, 2024
16 checks passed
@ternaus ternaus deleted the fix_ci branch October 21, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant