-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goon protocol version error #18
Comments
What does |
|
Should work. Could it be the case you have multiple You can also do an isolated test: clone porcelain repo, check it out at the version you're using and put your
It works for me in porcelain:master with goon:master. |
It works when inside porcelain, but using the same goon executable doesn't work inside my project. Using porcelain v2.0.0. |
@ericmj Can you reproduce it in a test project? Or is your project available publicly? |
Testing under Windows. Looks like there is an issue with the ackstr. The crypto.rand_bytes seems to produce bytes outside of the ascii range. When passed through cmd.exe, they get munged. Any passes on this test is luck of the draw for getting a ackstr that is completely printable. Examples of some ackstr values, and the return If I stub the ackstr to a static string that is printable, it passes the version check. |
@critch Thanks for the info! I can't say when I'll be able to address this, but I'll look into it at some point. |
@alco If you even have an idea you wish to toss out, I can spend a little time working on it at some point. |
I had a similar problem, downloaded latest release from the goon repo for linux_amd64. I then pulled the goon repo, and built from source myself. Might want to double check the release builds of |
@harmon25 Thanks for the info, I'll have to check it. |
Downloaded goon version 1.1.1 for windows 64. goon -v still shows 1.1.0, |
I was having this error when running elixir tests when my Changing: git clone https://github.com/alco/goon.git && cd goon && go build && export PATH=$PATH:"$(pwd)" && cd - To: git clone https://github.com/alco/goon.git $HOME/goon && cd $HOME/goon && go build && export PATH=$PATH:"$(pwd)" && cd - Fixed the error for me. Not sure if this is the problem others are having though. |
Getting the following error when trying to use the goon driver:
The text was updated successfully, but these errors were encountered: