Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to mark a hotfix as SNASPHOT #81

Closed
wtoscer opened this issue Dec 14, 2017 · 9 comments
Closed

add the ability to mark a hotfix as SNASPHOT #81

wtoscer opened this issue Dec 14, 2017 · 9 comments

Comments

@wtoscer
Copy link

wtoscer commented Dec 14, 2017

and when hotfix:finish is launched, remove -SNAPSHOT from version

@aleksandr-m
Copy link
Owner

@wtoscer
What about tag? Should it contain SNAPSHOT in it?

remove -SNAPSHOT from version

You mean in production branch? Development still has the SNAPSHOT?

@wtoscer
Copy link
Author

wtoscer commented Feb 5, 2018

Actually, if I run hotfix:start and I put 1.0.1-SNAPSHOT for the version, when I run hotfix:finish , I have 1.0.1-SNAPSHOT in my pom.xml on master.
I just want to keep my hotfix in SNAPSHOT mode while I'm currently developing, but remove it when finishing the hotfix (and the tag don't have to contains snapshot)

@marcschiely
Copy link

@aleksandr-m is there already a plan when the PR is merged and released? We are using your plugin and missing only this feature to have a complete hotfix process.

@aleksandr-m
Copy link
Owner

@marcschiely Have you tested this PR? Does it works as you want it to?
@wtoscer

@marcschiely
Copy link

@aleksandr-m I just tested if the PR does fulfill our needs. Looks like this is exactly what we wanted. So from my side +1 for this PR.

@aleksandr-m
Copy link
Owner

@marcschiely Good. Merged.

@marcschiely
Copy link

@aleksandr-m What is your plan to build the next release that contains this issue?

@aleksandr-m
Copy link
Owner

@marcschiely I'll try to do a release in the next couple of weeks.

@aleksandr-m
Copy link
Owner

@wtoscer @marcschiely 1.10.0 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants