Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid result when using anchors with non standard attributes #72

Closed
diegobanuelos opened this issue Apr 11, 2020 · 1 comment
Closed
Labels
next-release Issues that are solved and will be closed on the next release

Comments

@diegobanuelos
Copy link

Hi, great library. When making tests using your project I noticed an invalid result with the following case:

<a href="https://www.validurl.com" data-saferedirecturl="https://www.validurl.com/file.png">Valid text</a>

Reviewing your code, I added the attribute data-saferedirecturl to the htmlAttributes array in the dictionary and It worked; however, it will resolve only this specific case and not others with different non standard attribute names. What do you think about making the function isInsideAnchorTag ignore all the urls inside any property of an anchor?

@alexcorvi alexcorvi added the next-release Issues that are solved and will be closed on the next release label May 8, 2020
@alexcorvi
Copy link
Owner

Thank you for the report.
fixed in 2.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release Issues that are solved and will be closed on the next release
Projects
None yet
Development

No branches or pull requests

2 participants