Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Specification update for JSON feed #245

Closed
leonghui opened this issue Nov 27, 2019 · 1 comment
Closed

[docs] Specification update for JSON feed #245

leonghui opened this issue Nov 27, 2019 · 1 comment

Comments

@leonghui
Copy link
Contributor

Hi,

I added JSON feed to doc/specifications-support.md in #244.

There are some differences with the current implementation compared to the mappings recommended by the specs.

  1. The specs recommend mapping Atom and RSS link element to the home_page_url object, while Atom link with rel="self" should be mapped to feed_url.
  2. home_page_url is read using setUrl() in JsonParser but written using getLink() in JsonFormatter. Vice versa for feed_url.
  3. (typo) content_txt (should be content_text) in JsonFormatter
  4. For items, the specs recommend mapping media links/enclosure to item.attachments instead of item.image
@alexdebril
Copy link
Owner

hi,

thanks for this feedback, I've addressed most of the mentioned issues and just created a new issue for the attachments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants