Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0 rewrite #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

1.0.0 rewrite #6

wants to merge 5 commits into from

Conversation

alex35mil
Copy link
Owner

It's not ready yet, b/c part of this code was written blindly. After update to babel@6 fly is broken and I can't build the app to try it out. I'm waiting for comments on this issue: bucaran/fly/issues/120.

What's new in this release:

  • Generator is rewritten in ES6
  • All deps are updated to current versions
  • Babel 6
  • Immutable.js
  • Normalizr
  • Stylus -> SASS
  • CSS Modules support
  • Webpack configs are updated to handle all common types of assets + generate server bundles
  • Build system is rewritten: gulp removed, added fly + custom helpers

Check out diff, I could forget something.

What's ongoing & critical:

  • Fix builder (bucaran/fly/issues/120)
  • Fix deploy scripts for Node app (I removed all generated stuff out of repo, it needs to be handled during deploy)

@stereodenis
Copy link

@alexfedoseev hi! How is your release?)

@alex35mil
Copy link
Owner Author

@stereodenis Nothing new yet. lukeed/taskr#120 is still open and I have a lack of time to switch to some other build system. Hope fly will be fixed soon.

@alex35mil alex35mil mentioned this pull request Mar 12, 2016
@stereodenis
Copy link

@alexfedoseev fly issue is closed

@alex35mil
Copy link
Owner Author

@stereodenis Thanks for heads up! I'll check it out this weekend 👍

@stereodenis
Copy link

@alexfedoseev ping)

@alex35mil
Copy link
Owner Author

@stereodenis This weekend)

@inchr
Copy link

inchr commented Apr 16, 2016

@alexfedoseev WOW, I must just start a project tomorrow!!! I've subscribed to this issue! you think that will be done for this week ?

BTW great work!

@alex35mil
Copy link
Owner Author

@stereodenis @inchr Guys, I pushed everything I had on local, and tested new fly yesterday, but the issue wasn't resolved. If it's not gonna be fixed anytime soon, I'll try to switch to js generators (instead of async/await). I have very limited time on it, so next up on this will be on the next weekend.

@alex35mil
Copy link
Owner Author

@stereodenis @inchr I fixed all critical stuff in generator and it'd be cool if you'll try it out. Nevertheless, while I was fixing the things, there was a bunch of errors from linter (I need to update eslint config and also fix linter errors in the code), plus I noticed a number of legacy patterns all over the place, so I won't be releasing this one as is.

If you'd like to try it out, please pull this branch and run npm link in the root folder. Then you can use generator as usual. Any feedback is greatly appreciated!

@Kshitij-Banerjee
Copy link

Kshitij-Banerjee commented May 24, 2016

for rookies like me. .

  • need to do a npm run build before npm link...
  • need to install redux, react-redux as well.

worked after that.... thanks.

master is not working, and also the default generator is broken .. Would be great to upload this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants