notifyOnSuccess should make the form un-dirty #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex35mil
reviewed
Feb 23, 2019
There was a problem hiding this comment.
Thanks for PR! It's a bit tricky change in terms of being implicitly breaking, kind of. I'll take a little pause to think of possible consequences.
P.S. There are async containers that needs to be updated accordingly: Formality__FormAsyncOnBlur.re & Formality__FormAsyncOnChange.re.
src/Formality__Form.re
Outdated
| input: data, | ||
| status: FormStatus.Submitted, | ||
| fields: state.fields->Map.map(_ => Validation.Pristine), | ||
| }); | ||
| | None => React.Update({...state, status: FormStatus.Submitted}) |
There was a problem hiding this comment.
Yeah, this should also reset the forms dirty state in my opinion
…ded reset onto the case where none is supplied to notifyOnSuccess
|
Totally forgot to update the Async form, my bad 😅(done now) |
|
@steinararnason Sorry for the delay. PR is looking good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case at work where we need the form to not be dirty after using notifyOnSuccess so the save button on our form is disabled until the user edits some field again after submitting.
This PR adds that functionality 😁