Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fitting Laplace repeatedly #40

Closed
aleximmer opened this issue Aug 31, 2021 · 1 comment
Closed

Allow fitting Laplace repeatedly #40

aleximmer opened this issue Aug 31, 2021 · 1 comment
Assignees

Comments

@aleximmer
Copy link
Owner

There is no reason to prefent the .fit() method to be called repeatedly, for example after changing hyperparameters or on a different data set. Currently, this raises a ValueError here. Maybe raise a warning instead of simply reset the state to enable safe iterative fits.

@runame
Copy link
Collaborator

runame commented Dec 10, 2021

Fixed by #62.

@runame runame closed this as completed Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants