Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Only send tenant configuration if changed #513

Closed
willvedd opened this issue Feb 7, 2022 · 1 comment
Closed

Only send tenant configuration if changed #513

willvedd opened this issue Feb 7, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@willvedd
Copy link
Collaborator

willvedd commented Feb 7, 2022

Description

Originally spurring from #351 which was closed due to the project migration.

From the OP:

This modification makes it such that tenant setting flags will only be included in the PATCH /api/v2/tenants/settings call if they have changed. This proposed change addresses use cases for Auth0 private cloud and enterprise customers whose tenants do not allow updates of certain tenant settings flags. Even the mere presence of these flags in the API call, irrespective of the values changing or not, will cause the API to return an error response. With these proposed changes, the tenant setting flags will simply be omitted from the API call if unchanged, thus bypassing the issue altogether.

This issue, while appearing to be straightforward, is non-trivial to holistically address. I defer to the comments in #351 for explanation.

This would also fix #160 .

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@sergiught
Copy link
Collaborator

We have moved this issue over at auth0/terraform-provider-auth0#63 as this repo is now maintained at https://github.com/auth0/terraform-provider-auth0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants