Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Does not correctly handle immutable objects when hideRoot is false #34

Closed
leonaves opened this issue Feb 26, 2016 · 1 comment
Closed

Comments

@leonaves
Copy link

Issue is here: https://github.com/chibicode/react-json-tree/blob/master/src/index.js#L81-L105

The getChildNodes function does not consider if the object of type immutable and breaks the detection in obj-type.js. An easy fix would be an if objType(value) === 'Iterable' somewhere in that function but I haven't submitted a PR because I have a feeling you'd want it done a bit more carefully.

@leonaves leonaves changed the title Does not correctly handle immutable objects when hideRoot is true Does not correctly handle immutable objects when hideRoot is false Feb 26, 2016
@alexkuz
Copy link
Owner

alexkuz commented Apr 17, 2016

I think this one is outdated, I just checked - <JSONTree data={Immutable.map(data)} hideRoot />` works fine, so I'm closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants