-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [lang]-query-file
arg
#168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CI failing at https://github.com/alexpovel/srgn/actions/runs/11693746764/job/32611046155?pr=168#step:7:321 because some GitHub Actions runners we get are on Rust 1.82, some on 1.81. Flaky! But irrelevant. Will maybe fix on |
If you rebase onto
|
b0853ed
to
cdc04bc
Compare
Ah good quality of life improvement!
Done! a77b149.
Good to get that confusing issue fixed.
🥳 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 88.34% 88.48% +0.14%
==========================================
Files 33 33
Lines 1930 1920 -10
==========================================
- Hits 1705 1699 -6
+ Misses 225 221 -4 ☔ View full report in Codecov by Sentry. |
Great, merged! Thanks for your work, I'll release soon and then you can finally use it. |
Nice! I'll be trying it out as part of the CI process of a 200K LOC Rust project to perform custom linting. |
Polish off #144