Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how we import json macro #208

Closed
jsha opened this issue Oct 25, 2020 · 2 comments
Closed

Update how we import json macro #208

jsha opened this issue Oct 25, 2020 · 2 comments

Comments

@jsha
Copy link
Collaborator

jsha commented Oct 25, 2020

Right now serde_macros.rs says:

// this file is borrowed in its entirety until macro_reexport stabilizes.
// https://github.com/rust-lang/rust/issues/29638

That issue is closed in preference to rust-lang/rust#49982, which links to rust-lang/rust#35896. I'm not sure what the current status of everything is but I suspect we can update this.
@algesten
Copy link
Owner

algesten commented Oct 25, 2020 •
edited
Loading

We can! I was thinking about that today. We should be able to remove this file now.

@jsha
Copy link
Collaborator Author

jsha commented Nov 15, 2020

Done in release-2.0 branch.

@jsha jsha closed this as completed Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsha @algesten