feat(algolia): fix highlighting hit type #452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our requirements for highlighting a hit.
Description
We used to expect a hit to contain an
objectID
property because Algolia hits owns it. However, we also support highlighting for Recent Searches and facet hits, which aren't strictly Algolia hits, and therefore don't own anobjectID
property.We now expect an
_highlightResult
forhighlightHit
and_snippetResult
forsnippetHit
, which is more accurate.Related
getAlgoliaFacetHits
preset #451 (comment)