Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): prevent id incrementation when toggling detached mode #489

Merged
merged 7 commits into from
Mar 5, 2021
Merged

fix(js): prevent id incrementation when toggling detached mode #489

merged 7 commits into from
Mar 5, 2021

Conversation

shortcuts
Copy link
Member

Summary

When toggling detached mode, the id was incremented by generateAutocompleteId.

  • Move generateAutocompleteId to the shared library
  • Add tests

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 4, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 38bc0a7:

Sandbox Source
@algolia/js-example Configuration
@algolia/react-renderer-example Configuration
@algolia/query-suggestions-with-rich-hits-example Configuration
@algolia/query-suggestions-example Configuration
@algolia/qs-with-rs-example Configuration
@algolia/qs-with-inline-categories-example Configuration
@algolia/recently-viewed-items-example Configuration

francoischalifour
francoischalifour approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@francoischalifour francoischalifour changed the title fix(generateAutocompleteId): prevent id incrementation when toggling detached mode fix(js): prevent id incrementation when toggling detached mode Mar 5, 2021
@shortcuts shortcuts merged commit fe2bf13 into next Mar 5, 2021
@shortcuts shortcuts deleted the fix/defaultAutocompleteId branch March 5, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoischalifour francoischalifour francoischalifour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shortcuts @francoischalifour