fix(toggle): ensure facet is present (#1613)

algolia · Sep 26, 2018 · e914ff6 · e914ff6
1 parent 6044273
commit e914ff6
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 3 deletions.
diff --git a/packages/react-instantsearch-core/src/connectors/__tests__/connectToggleRefinement.js b/packages/react-instantsearch-core/src/connectors/__tests__/connectToggleRefinement.js
@@ -121,7 +121,7 @@ describe('connectToggleRefinement', () => {
       expect(actual.canRefine).toBe(false);
     });
 
-    it('expect `canRefine` to be `false` without the facet', () => {
+    it('expect `canRefine` to be `false` without the facet values', () => {
       const props = { attribute: 'shipping', value: true };
       const searchState = {};
       const searchResults = createSingleIndexSearchResults({
@@ -134,6 +134,19 @@ describe('connectToggleRefinement', () => {
       expect(actual.canRefine).toBe(false);
     });
 
+    it('expect `canRefine` to be `false` without the facet', () => {
+      const props = { attribute: 'shipping', value: true };
+      const searchState = {};
+      const searchResults = createSingleIndexSearchResults({
+        disjunctiveFacets: [],
+        facets: {},
+      });
+
+      const actual = getProvidedProps(props, searchState, searchResults);
+
+      expect(actual.canRefine).toBe(false);
+    });
+
     it('expect `canRefine` to be `false` without results', () => {
       const props = { attribute: 'shipping', value: true };
       const searchState = {};
@@ -463,7 +476,7 @@ describe('connectToggleRefinement', () => {
       expect(actual.canRefine).toBe(false);
     });
 
-    it('expect `canRefine` to be `false` without the facet', () => {
+    it('expect `canRefine` to be `false` without the facet values', () => {
       const props = { attribute: 'shipping', value: true };
       const searchState = createMultiIndexSearchState();
       const searchResults = createMultiIndexSearchResults({
@@ -476,6 +489,19 @@ describe('connectToggleRefinement', () => {
       expect(actual.canRefine).toBe(false);
     });
 
+    it('expect `canRefine` to be `false` without the facet', () => {
+      const props = { attribute: 'shipping', value: true };
+      const searchState = createMultiIndexSearchState();
+      const searchResults = createMultiIndexSearchResults({
+        disjunctiveFacets: [],
+        facets: {},
+      });
+
+      const actual = getProvidedProps(props, searchState, searchResults);
+
+      expect(actual.canRefine).toBe(false);
+    });
+
     it('expect `canRefine` to be `false` without results', () => {
       const props = { attribute: 'shipping', value: true };
       const searchState = createMultiIndexSearchState();

diff --git a/packages/react-instantsearch-core/src/connectors/connectToggleRefinement.js b/packages/react-instantsearch-core/src/connectors/connectToggleRefinement.js
@@ -81,7 +81,11 @@ export default createConnector({
       this.context
     );
 
-    const allFacetValues = results && results.getFacetValues(attribute);
+    const allFacetValues =
+      results && results.getFacetByName(attribute)
+        ? results.getFacetValues(attribute)
+        : null;
+
     const facetValue =
       // Use null to always be consistent with type of the value
       // count: number | null