This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(connectInfiniteHits): always provide an array for hits #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 868bccb https://deploy-preview-1064--react-instantsearch.netlify.com |
samouss
force-pushed
the
fix/infinite-hits-empty
branch
2 times, most recently
from
c7f53e5 to
5774ad5
Compare
samouss
force-pushed
the
fix/infinite-hits-empty
branch
from
5774ad5 to
868bccb
Compare
samouss
added a commit
that referenced
this pull request
Mar 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some cases it might happen that on the first render the
resultsis not empty. It will happen if the component has been already mount previously for example. In that the case the widget will return anundefinedvalue for this hits because all the condition arefalse. So we need to ensure that on every render thehitswill be an array.