This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(indexUtils): avoid throw an error on cleanUp multi indices #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 8061b03 https://deploy-preview-1265--react-instantsearch.netlify.com |
vvo
approved these changes
May 23, 2018
samouss
force-pushed
the
fix/clean-up-multi-index
branch
from
bc0ec88 to
8061b03
Compare
samouss
added a commit
that referenced
this pull request
May 28, 2018
<a name="5.1.0"></a> # [5.1.0](v5.0.3...v5.1.0) (2018-05-28) ### Bug Fixes * **connectInfiniteHits:** always set a value for previous page ([#1195](#1195)) ([4c218d5](4c218d5)) * **indexUtils:** avoid throw an error on cleanUp multi indices ([#1265](#1265)) ([12f5ace](12f5ace)) ### Features * **searchClient:** Add support for custom Search Clients ([#1216](#1216)) ([174cc28](174cc28))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR solve an issue when we try to clean up a index that is not in the searchState. It might happen with a multi indices configuration. You can take look at this example for more context (switch on the Wikis tabs).
Now, we make sure that the index exists on the
searchStatebefore trying to remove the value. You can take a look at this commit for the fix.I also rewrite a bit the function that handle the clean up. Instead of relying on one function we now have two function dedicated to the single / multi index. I found a bit hard to follow the code with the extended ternaries. I replaced them with early returns.