Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

fix: sync algoliasearch version #1879

Merged
merged 1 commit into from
Jan 9, 2019
Merged

fix: sync algoliasearch version #1879

merged 1 commit into from
Jan 9, 2019

Conversation

samouss
Copy link
Collaborator

@samouss samouss commented Jan 9, 2019

Summary

Without this change the UMD build of the legacy package is broken. There are a require calls inside the build. With this change they disappear from the output.

With issue:

https://unpkg.com/react-instantsearch@5.4.0-beta.0/umd/Dom.js

Without issue:

https://unpkg.com/react-instantsearch@5.3.2/umd/Dom.js

@samouss samouss force-pushed the fix/algoliasearch branch from e8b0372 to a04cbd9 Compare January 9, 2019 16:46
@algobot
Copy link
Contributor

algobot commented Jan 9, 2019

Deploy preview for react-instantsearch ready!

Built with commit e8b0372

https://deploy-preview-1879--react-instantsearch.netlify.com

@algobot
Copy link
Contributor

algobot commented Jan 9, 2019

Deploy preview for react-instantsearch ready!

Built with commit a04cbd9

https://deploy-preview-1879--react-instantsearch.netlify.com

@samouss samouss merged commit 40f9c26 into master Jan 9, 2019
@samouss samouss deleted the fix/algoliasearch branch January 9, 2019 17:03
samouss added a commit that referenced this pull request Jan 10, 2019
# [5.4.0-beta.1](v5.4.0-beta.0...v5.4.0-beta.1) (2019-01-10)

### Bug Fixes

* **deps:** sync algoliasearch version ([#1879](#1879)) ([40f9c26](40f9c26))
* **maps:** use stable version for peer deps ([#1887](#1887)) ([9055167](9055167))
@samouss
Copy link
Collaborator Author

samouss commented Jan 10, 2019

The issue is now fixed with the version v5.4.0-beta.1.

https://unpkg.com/react-instantsearch@5.4.0-beta.1/umd/Dom.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants