This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(highlight): allow array as "attribute" #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already allowed here via lodash.get & in v6 via the new helper in #2461 This allows to avoid conflicts when one of the keys is a string including a `.` itself.
|
Deploy preview for react-instantsearch ready! Built with commit c78d8d2 https://deploy-preview-2474--react-instantsearch.netlify.com |
samouss
approved these changes
May 22, 2019
samouss
pushed a commit
that referenced
this pull request
Jun 4, 2019
# [5.7.0](v5.6.0...v5.7.0) (2019-06-04) ### Bug Fixes * **highlight:** allow array as "attribute" ([#2474](#2474)) ([9dc829a](9dc829a)), closes [#2461](#2461) * **indexUtils:** allow index with dots in it ([#2350](#2350)) ([f91906f](f91906f)) ### Features * **voiceSearch:** add voice search widget ([#2316](#2316)) ([0e3b124](0e3b124))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already allowed here via lodash.get & in v6 via the new helper in #2461
This allows to avoid conflicts when one of the keys is a string including a
.itself.