This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(connectQueryRules): fix crash when using connectQueryRules in multiple indexes #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
yannickcr
changed the title
|
Deploy preview for react-instantsearch ready! Built with commit 3edf700 https://deploy-preview-2903--react-instantsearch.netlify.com |
francoischalifour
approved these changes
Mar 27, 2020
yannickcr
added a commit
that referenced
this pull request
May 18, 2020
# [6.5.0](v6.4.0...v6.5.0) (2020-05-18) ### Bug Fixes * **connectQueryRules:** fix crash when using connectQueryRules with multiple indexes ([#2903](#2903)) ([c66d612](c66d612)) * **core:** fix maximum call stack size exceeded ([#2926](#2926)) ([7e883df](7e883df)) ### Features * **SearchBox:** provide input element ref ([#2913](#2913)) ([b41bff2](b41bff2))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2902
searchState.indicesisundefinedif the widget is initialized with an emptysearchState, triggering an error during the initial call togetSearchParameters.This PR fix it by adding a check on
searchState.indicespresence before trying to use it.