This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat: custom root index #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good when skimming |
|
Deploy preview ready! Built with commit 1cc2acb |
mthuret
approved these changes
Jan 4, 2018
samouss
force-pushed
the
fix/custom-root-index
branch
from
9d58256 to
1cc2acb
Compare
samouss
added a commit
that referenced
this pull request
Jan 9, 2018
<a name="4.4.1"></a> ## [4.4.1](v4.4.0...v4.4.1) (2018-01-09) ### Bug Fixes * **SearchBox**: clear SearchBox without search as you type ([#802](#802)) ([c49b2b6](c49b2b6)) * **connectRange:** check if facet exist before access ([#797](#797)) ([6520760](6520760)) * **stories:** avoid to use linear-background it breaks Argos every time ([#804](#804)) ([0beded7](0beded7)) * **stories:** limit hits per page on Index ([#806](#806)) ([6eb14d3](6eb14d3)) ### Features * **Index:** allow custom root ([#792](#792)) ([d793b0a](d793b0a))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a previous PR #770 we have introduce the
rootprop for theInstantSearchcomponent. But we forgot to handle the case for theIndexcomponent. The test ofcreateInstantSearchhas also be updated because the previous test didn't tested therootprop.Enable the possibility to pass custom
rootprop to Index. Don't introduce any breaking change, since we use the root ofcreateIndexasdefaultProps.Result
You can play with the example in Storybook.